[ https://issues.apache.org/jira/browse/THRIFT-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133160#comment-14133160 ]
ASF GitHub Bot commented on THRIFT-2701: ---------------------------------------- GitHub user hcorg opened a pull request: https://github.com/apache/thrift/pull/215 THRIFT-2701 - compiler: T_ONEWAY type used for oneway methods https://issues.apache.org/jira/browse/THRIFT-2704 You can merge this pull request into a Git repository by running: $ git pull https://github.com/hcorg/thrift t_oneway Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/215.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #215 ---- commit 389f89fc9f5027b43efb7054d5ae3192d1fc41f2 Author: Konrad Grochowski <hc...@minions.org.pl> Date: 2014-09-14T11:09:48Z THRIFT-2701 - compiler: T_ONEWAY type used for oneway methods instead of T_CALL ---- > Update TCompactProtocol.php > --------------------------- > > Key: THRIFT-2701 > URL: https://issues.apache.org/jira/browse/THRIFT-2701 > Project: Thrift > Issue Type: Bug > Components: PHP - Library > Reporter: Jens Geyer > > GitHub user anjz opened a pull request: > https://github.com/apache/thrift/pull/212 > Update TCompactProtocol.php > Removed `strrev` from `readDouble` and `writeDouble` functions. I found > problems reading a double that was generated with the python library. > You can merge this pull request into a Git repository by running: > $ git pull https://github.com/anjz/thrift master > Alternatively you can review and apply these changes as the patch at: > https://github.com/apache/thrift/pull/212.patch > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > This closes #212 > > ---- > commit c5d971fdf660f38426d3109a3e844ae6d1beb624 > Author: anjz <anar...@gmail.com> > Date: 2014-09-11T15:52:07Z > Update TCompactProtocol.php > > Removed `strrev` from `readDouble` and `writeDouble` functions. I found > problems reading a double that was generated with the python library. > ---- -- This message was sent by Atlassian JIRA (v6.3.4#6332)