[
https://issues.apache.org/jira/browse/THRIFT-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133165#comment-14133165
]
ASF GitHub Bot commented on THRIFT-2704:
----------------------------------------
GitHub user hcorg opened a pull request:
https://github.com/apache/thrift/pull/216
THRIFT-2704 - compiler: T_ONEWAY type used for oneway methods
https://issues.apache.org/jira/browse/THRIFT-2704
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hcorg/thrift t_oneway2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/216.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #216
----
commit b82445fe8110440c3270951292819ce49731c17f
Author: Konrad Grochowski <hc...@minions.org.pl>
Date: 2014-09-14T11:09:48Z
THRIFT-2704 - compiler: T_ONEWAY type used for oneway methods instead of
T_CALL
----
> generated oneway functions encode as T_CALL not T_ONEWAY
> --------------------------------------------------------
>
> Key: THRIFT-2704
> URL: https://issues.apache.org/jira/browse/THRIFT-2704
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Compiler
> Affects Versions: 0.9.1
> Reporter: Konrad Grochowski
>
> Steven Varga wrote:
> {quote}
> Hi,
> the following service generates oneway RPC call flagged with T_CALL flag as
> opposed to expected T_ONEWAY; I need the T_ONEWAY flag to implement proper
> zero MQ message passing. Zero MQ message passing system differentiates
> between request - reply patterns and push - pull ones at socket level;
> Am I doing something wrong ?
> best,
> steve
> service foo {
> oneway void bar( 1:string value );
> }
> void fooClient::put( const std::string& value ) {
> send_bar( value ); // <- this is correct that recv_xxx is missing
> }
> // ----- incorrect or unreasoned T_CALL instead of T_ONEWAY
> void fooClient::send_bar(const std::string& value) {
> int32_t cseqid = 0;
> oprot_->writeMessageBegin("bar", ::apache::thrift::protocol::T_CALL,
> cseqid);
> ....
> }
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
