[
https://issues.apache.org/jira/browse/THRIFT-2688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137550#comment-14137550
]
Konrad Grochowski commented on THRIFT-2688:
-------------------------------------------
sounds very good
this way some headers could get really light (not including TProtocol etc -
currently they pollute client code quite heavily)
please take a look at THRIFT-2692 - with possibility of testing and refactoring
such transition should be easy to made (I could look into it :) )
> Generating *Null implementations should be optional
> ---------------------------------------------------
>
> Key: THRIFT-2688
> URL: https://issues.apache.org/jira/browse/THRIFT-2688
> Project: Thrift
> Issue Type: New Feature
> Components: C++ - Compiler
> Reporter: Konrad Grochowski
> Attachments: THRIFT-2688.patch
>
>
> *Null implmentations introduce another level of ugly diamond shaped
> inheritance (with extended ifaces), which - among other things - leads to a
> lot of warnings on MSVC ("inheritance via dominance" C4250).
> Additionallly it just clobbers generated header as when stubs are needed
> GoogleMock/Turtle could/should be used.
> But I do understand requirement for backward compatibility, so in attached
> patch I've added option to ommit nulls generation, so still by default
> they'll be generated
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
