[ 
https://issues.apache.org/jira/browse/THRIFT-2725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151229#comment-14151229
 ] 

Randy Abernethy commented on THRIFT-2725:
-----------------------------------------

One thing I think we should try to enforce globally is a white space policy. 
This has sort of been implied for some time but it would be nice to make it 
explicit.

I suggest:

White Space Policy
===============
1. Spaces must always be used in source files for indentation, Tabs are 
forbidden.
   Rational - Everyone has different tab settings. With tabs indenting source, 
good code in one editor looks like an error in another editor. We have a huge 
community and a vast set of languages. Spaces are the common denominator.

2. Line Endings must always be LF only.
   Rational - Mixing CRLF with LF causes build failure on our key CI platforms.

3. Lines must not end with trailing spaces.
   Rational - Invisible characters at the end of a line take up space in the 
repo, cause git warnings and can cause identical code to report line changes 
creating wasteful commits.

> General coding standards
> ------------------------
>
>                 Key: THRIFT-2725
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2725
>             Project: Thrift
>          Issue Type: Sub-task
>            Reporter: Konrad Grochowski
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to