[
https://issues.apache.org/jira/browse/THRIFT-2746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153743#comment-14153743
]
Konrad Grochowski commented on THRIFT-2746:
-------------------------------------------
will also solve THRIFT-2711
it's a shame, but it must be done: +1
I saw a lot of unnecessary (t_type*) casts like
{code}
((t_type*)(*f_iter)->get_type() // f_iter contains t_field*
{code}
you could use this patch to clean up code a little ;) (and make it a little bit
safer)
> Compiler C++98 conformance
> --------------------------
>
> Key: THRIFT-2746
> URL: https://issues.apache.org/jira/browse/THRIFT-2746
> Project: Thrift
> Issue Type: Sub-task
> Components: C++ - Compiler, Haskell - Compiler
> Affects Versions: 0.9.2
> Environment: all
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Fix For: 0.9.2
>
> Attachments: 0001-Thrift-Compiler-fixes-to-keep-code-C-98.patch
>
>
> This is the piece of the CentOS 6.5 patch that cleans up the compiler build
> errors due to C + + 11 code in the Haskell and C++ generators.
> C + + 11 elements replaced:
> - Ranged for loops: for ( auto x : container )
> - Type deduction: auto
> - NULL assignment to boost::shared_ptr: replaced with .reset()
> - Constructor initialization of boost::shared_ptr with 0: replaced with ""
> - Nondeterministic compiler dependent for loop scoping: changed iterators
> to inner scope
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
