[
https://issues.apache.org/jira/browse/THRIFT-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154170#comment-14154170
]
Randy Abernethy commented on THRIFT-2744:
-----------------------------------------
Update:
- The patches commited in the sub tasks here jave all built on Trusty and run
make check clean on the target lang lib
- That said, the Trusty make check on all langs still fails (a Python problem
was my last issue). I will continue to try to get the Trusty vagrant box and
the Centos vagrant box to build and make clean in the days ahead (know others
are working on this as well, go team!)
- There are several pieces of the master patch on this ticket not yet applied:
1 thrift//lib/cpp/test/Makefile.am has unused bits like
"concurrency_test_SOURCES". This is because these tests are commented out
because they take too long (see Roger/Konrad disc on other channel). Commenting
the test but leaving the variables defined on the test causes build failure on
Centos. This is just a simple policy update, if we comment out the test we need
to comment all of the Makefile.am derived test_* stuff.
2 AUTOMAKE_OPTIONS = serial-tests. In d and d/test this option blows up
the Centos build. Not sure why. Need to find a way to make it work in both
Ubuntu and Centos.
3 thrift/lib/rb/spec/server_spec.rb line fails on Centos. Removing it
fails on Ubuntu. Need to find a mutual solution here.
4 thrift/test/py.twisted/Makefile.am line 23 declares an undefined
$(TRIAL) rule which blows up. The rule is not operable anyway and should be
fixed or removed.
> Vagrantfile for Centos 6.5
> --------------------------
>
> Key: THRIFT-2744
> URL: https://issues.apache.org/jira/browse/THRIFT-2744
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process, Test Suite, Tutorial
> Affects Versions: 0.9.2
> Environment: all
> Reporter: Randy Abernethy
> Assignee: Randy Abernethy
> Attachments: 0001-vagrant-updates-8.patch
>
>
> Apache Thrift needs better Centos support.
> Apache Thrift build and test has been missing solid Centos support. Getting
> the full Thrift platform to build on Centos is a rough road, largely because
> commits take place without testing on Centos.
> Kerry Kim, director of Linux markets for SuSE, in a January 2014 LinuxInsider
> story ranked enterprise Linux platforms: Red Hat (60 percent market share),
> SuSE (30 percent market share), Oracle (5 to 8 percent market share) and
> Ubuntu (less than 4 percent) http://www.linuxinsider.com/story/79717.html
> Testing with Centos provides the opportunity to catch additional defects in
> code, build and cross platform operation which aren't reported on Ubuntu
> alone. A particular concern that Centos will help trap is the addition of C+
> + 11 code to the Thrift compiler and or C+ + 98 lib. A cpp11 lib is a
> necessary addition but we should keep the compiler and existing libs free of
> C+ + 11 so that they will build on LTS platforms.
> This Vagrantfile is a work in progress. It currently supports building the
> compiler and almost all of the language libraries.
> Adding Centos and a Windows vm to the CI process prior to v1.0 would be a
> significant cross platform uptick. With Ubuntu, Centos and Windows, Thrift
> would have the cross platform test base that it deserves.
> As a side note: We should either make sure commits pass CI or just turn off
> the CI everywhere so that we do not waste power, CPU cycles and email
> bandwidth. The CI BUILD FAILED emails are far too frequent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
