[ 
https://issues.apache.org/jira/browse/THRIFT-2674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155348#comment-14155348
 ] 

Jens Geyer commented on THRIFT-2674:
------------------------------------

{quote}
It seems that my github pull request is not tracked in this Jira, is there 
anything else I need to do to make that happen?
{quote}

Ideally one mentions the THRIFT-number in the pull request. Doing that later in 
a comment works too, but we lose the initial pull request message and have to 
look up that in the mailing list archives, if needed for some reason. So the 
recommended order is JIRA first, pull request second, mentioning the number 
from step 1

> JavaScript: declare Accept: and Content-Type: in request
> --------------------------------------------------------
>
>                 Key: THRIFT-2674
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2674
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library
>            Reporter: Stig Bakken
>            Priority: Minor
>         Attachments: js-type.diff
>
>
> When a JS client communicates with a backend supporting several encodings, 
> knowing which protocol to use is a bit kludgy.  This patch tries to fix that 
> by always setting the Accept: and Content-Type: request headers to 
> "application/json".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to