[ 
https://issues.apache.org/jira/browse/THRIFT-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156143#comment-14156143
 ] 

alisdair sullivan commented on THRIFT-1191:
-------------------------------------------

i've tried to write a minimal test case for this issue but i'm unable to 
reproduce the behavior described. i'm not really sure what "Let's then remove 
field 2 from TheTest structure" in Anatoly's explanation means, exactly. i've 
written tests that both leave the second field undefined when writing and then 
reading and that write using a thrift definition with both fields and then read 
with a thrift definition with the second field removed

the test doesn't hurt and could be merged but unless someone can point out 
something i've missed i am not sure this solves the issue. i am not really sure 
what the issue is

> Erlang binding throws during skipping fields of composite type (maps, lists, 
> structs, sets)
> -------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-1191
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1191
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Library
>            Reporter: Anatoly Kanivetsky
>            Assignee: alisdair sullivan
>         Attachments: THRIFT-1191.patch
>
>
> Erlang binding throws during skipping fields of composite type (maps, lists, 
> structs, sets)
> Here's the pull request with this fix:
> https://github.com/apache/thrift/pull/3 here is the patch
> Here's the fix only:
> https://github.com/chaos-ad/thrift/commit/d70576209ae01f7ae56a1afccc1210d120b0ecde



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to