[
https://issues.apache.org/jira/browse/THRIFT-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chaoyu Tang updated THRIFT-2046:
--------------------------------
Attachment: THRIFT-2046_3.patch
[~jfarrell] & [~brocknoland] I rebased the code and recreated the patch (see
attached THRIFT-2046_3.patch), it has been tested with Hive.
The reason that the previous patch was broken is it was stale. THRIFT-2551 was
committed after that patch actually uses the variable rejections which has been
removed in that patch, so you saw the compile error.
In this new patch, I also added the retries for OOMError (from THRIFT-2551)
till timeout.
Thanks for the review.
> The worktask can be timed out in TThreadPoolServer (Java) when the max#
> thrift thread is reached
> ------------------------------------------------------------------------------------------------
>
> Key: THRIFT-2046
> URL: https://issues.apache.org/jira/browse/THRIFT-2046
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.9
> Reporter: Chaoyu Tang
> Assignee: Jake Farrell
> Fix For: 0.9.2
>
> Attachments: THRIFT-2046.patch, THRIFT-2046_1.patch,
> THRIFT-2046_2.patch, THRIFT-2046_3.patch
>
>
> Once the max# of thrift threads is reached, a new task (workprocess) is
> attempted to be executed in an infinite loop, then the client may hang.
> An improvement is to introduce a task timeout. after a certain time, if the
> task is still not got queued to be executed. It will be invalidated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
