[ https://issues.apache.org/jira/browse/THRIFT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160578#comment-14160578 ]
ASF GitHub Bot commented on THRIFT-809: --------------------------------------- Github user noazark commented on the pull request: https://github.com/apache/thrift/pull/232#issuecomment-58058863 Ahh, well the problem is not from my branch after all. See: https://travis-ci.org/apache/thrift/jobs/36996719#L4277 > Javascript client: Please make required fields actually required. > ------------------------------------------------------------------ > > Key: THRIFT-809 > URL: https://issues.apache.org/jira/browse/THRIFT-809 > Project: Thrift > Issue Type: Improvement > Components: JavaScript - Compiler > Reporter: Jordan > > If fields are marked as required then I think that we should be forced to > supply all of them, even if supplied with null values. Currently, I am able > to construct an object without all of the required fields, send it to my > backend, and nowhere does an error occur before sending. This should fail > fast at the client. Instead, on the server I get null values. Null is so > different than unspecified. > Thanks! -- This message was sent by Atlassian JIRA (v6.3.4#6332)