[ 
https://issues.apache.org/jira/browse/THRIFT-2689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161582#comment-14161582
 ] 

alisdair sullivan commented on THRIFT-2689:
-------------------------------------------

the haskell compiler backend does the same thing as the erlang backend and 
generates identical structs from structs with different names (due to mutating 
struct names in compilation)

i don't know enough about haskell to know what the appropriate fix is in this 
case -- there may not be one -- so i've just removed the problematic structure 
from the NameConflictTest.thrift definition

> struct names that differ only in capitalization of first character generate 
> broken erlang code
> ----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-2689
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2689
>             Project: Thrift
>          Issue Type: Bug
>          Components: Erlang - Compiler, Erlang - Library
>            Reporter: alisdair sullivan
>            Assignee: alisdair sullivan
>            Priority: Minor
>             Fix For: 0.9.2
>
>
> the following thrift specification generates broken erlang code:
> struct invalid { /* contents of struct are irrelevent */ }
> struct Invalid { /* still irrelevent }
> the compiler currently renames any struct that starts with a capital so that 
> it starts with a lowercase letter. instead, it should leave names intact and 
> use proper erlang syntax in generation. the attached patch does exactly that
> this does break backwards compatibility



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to