[
https://issues.apache.org/jira/browse/THRIFT-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161901#comment-14161901
]
Ben Craig commented on THRIFT-2717:
-----------------------------------
I agree that those are problems. I think that those should be fixed. I would
prefer to have those problems fixed without requiring C\+\+11.
We talked about something in a ticket that I am currently unable to find.
Basically, instead of adding compiler switches, we could instead generate a lot
of different cpp and header files. Each pair of files could contain a
different option (cob style, template style, unordered maps, boost::optional
returns). For compatibility, we would still generate files with the same name
as the .cpp and .h files that we currently generate, and those would #include
the relevant implementation files needed.
I think that approach could solve the header pollution, non-compliant variable
names, and (obviously) the "do all" headers. It also gives us room to generate
C\+\+98 and C\+\+11 code with --gen cpp... so long as the generated code goes
to different files.
> C++11 generator
> ---------------
>
> Key: THRIFT-2717
> URL: https://issues.apache.org/jira/browse/THRIFT-2717
> Project: Thrift
> Issue Type: New Feature
> Components: C++ - Compiler
> Reporter: Konrad Grochowski
>
> instead of adding another set of options to 'old' cpp generator I've started
> creating new one in:
> https://github.com/hcorg/thrift/tree/cpp11_generator
> using old as an reference
> main goals:
> * code compatible with old librart (at least for first tests, new lib and
> compiler switches can be added later)
> * no more ugly {{__isset}} structure -> boost::optional for optional values
> * as a result - no more {{__}} in names, which violates C++ standard
> * all generation code will have own unit tests (TDD used wherever possible)
> * generated types headers independent from Thrift header, to allow other
> layers of application using generated types without dependency leaks
> * each type will generate own header/cpp file - easier for user to include
> only used parts.
> * unordered map/sets
> * returning using move semantics, no more ugly 'return via output parameter'
> (still possible as option thou - sometimes it's needed for performance)
> * async client using boost::future
> * enum classes
> * initializer lists for constants (maybe)
> I'm aiming in C++11 subset available in gcc 4.8 and MSVC 2013
> currently I have only complete enum generation, but work is in progress
> all comments etc are very welcome :)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
