[ 
https://issues.apache.org/jira/browse/THRIFT-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171586#comment-14171586
 ] 

Roger Meier commented on THRIFT-2784:
-------------------------------------

MyEnum5 was introduced with THRIFT-2513 and it is not used.
I agree with Konrad, we can just remove the enum as long as all the values are 
commented out.

> Eliminate compiler warnings in generated C++ code
> -------------------------------------------------
>
>                 Key: THRIFT-2784
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2784
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler
>    Affects Versions: 0.9.1
>            Reporter: John Campbell
>            Assignee: Roger Meier
>            Priority: Minor
>         Attachments: thrift-2784-eliminate_generated_cpp_warnings.patch
>
>
> Generated C++ classes generate compiler warnings when the using code is 
> compiled with -Wall -Wextra -pedantic.
> Specifically, there are two types of warnings in the generated code:
> 1. Exceptions don't call parent constructor
> 2. Unused warnings
> (there may be others in the generated code, however no others have been found 
> at this time)
> Ideally, the generated C++ code should not have these errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to