GitHub user captncraig opened a pull request:
https://github.com/apache/thrift/pull/259
Backout
It has been pointed out to me that
https://github.com/apache/thrift/pull/249 was wrong. It was not needed to allow
server sockets to use buffering. The correct way is to pass in a
TBufferedTransportFactory to the server. This will create buffered sockets as
the processor starts up.
This change creates extra buffering, and is actually a real pain to
deactivate. Sorry.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/captncraig/thrift backout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/259.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #259
----
commit 4511d4835d0b0fe937edb447ada7193b4c3cb787
Author: Craig Peterson <[email protected]>
Date: 2014-11-10T22:26:28Z
backing out buffered sockets the wrong way
commit 6e9e494b2a6470ee2d27d7d60b879e4ebd744eaa
Author: Craig Peterson <[email protected]>
Date: 2014-11-10T22:29:22Z
fix compile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
