[ 
https://issues.apache.org/jira/browse/THRIFT-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209859#comment-14209859
 ] 

Konrad Grochowski commented on THRIFT-2729:
-------------------------------------------

[~roger.meier], you can check 
https://github.com/hcorg/thrift/commit/8b23feefdf37139ccbf31e87c99adfcfe6a07a3f 
to see how much .clang-format would change current code.

I am not a big fan of 'global reformatting' but sometimes it's better to do it 
once and then keep it clean.
Also: there are things I don't like about clang-format style, but there's no 
better tool so I think that switching to it's style it's the best what C++ 
programmer can do right now ;)

Still, until release of clang 3.6 (which supports {{// clang-format off}}) some 
files (like {{PlatformSocket.h}}) will need to be treated with care :)

If I get some support for that commit I can push it to repo :)

> C++ coding standards
> --------------------
>
>                 Key: THRIFT-2729
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2729
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: C++ - Library
>            Reporter: Konrad Grochowski
>         Attachments: .clang-format, CPPLINT.cfg
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to