[ https://issues.apache.org/jira/browse/THRIFT-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212416#comment-14212416 ]
Konrad Grochowski commented on THRIFT-1548: ------------------------------------------- is there a way to write test for that issue? > PHP TCompactProtocol always reads bools as false > ------------------------------------------------ > > Key: THRIFT-1548 > URL: https://issues.apache.org/jira/browse/THRIFT-1548 > Project: Thrift > Issue Type: Bug > Components: PHP - Library > Affects Versions: 0.8 > Reporter: Gregory Hart > Attachments: TCompactProtocol.php.patch > > > In TCompactProtocol::readFieldBegin, $field_type should be compared to > COMPACT_TRUE or COMPACT_FALSE before being converted to a TType. Otherwise, > $field_type will be converted to TType::BOOL (0x02) and will always match > COMPACT_FALSE (0x02). -- This message was sent by Atlassian JIRA (v6.3.4#6332)