GitHub user cvlchinet opened a pull request:
https://github.com/apache/thrift/pull/283
Remove strange public Peek() from GO transports
I've been seeing this public Peek() function in the GO library for a while,
but
still cannot figure out any sense to it.
If there are useless, we can remove them right?
This PR removes the public Peek() from the implemented transports.
All tests still pass.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cvlchinet/thrift go-peek
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #283
----
commit ac64c3395beaa2fbc6576fabfd3835d90b6737ff
Author: Chi Vinh Le <c...@chinet.info>
Date: 2014-11-24T18:44:16Z
Remove public Peek fom transports
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
