[ https://issues.apache.org/jira/browse/THRIFT-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223329#comment-14223329 ]
Jens Geyer edited comment on THRIFT-2851 at 11/24/14 7:14 PM: -------------------------------------------------------------- {quote} If there are useless, we can remove them right? {quote} It may not be the best way how it is implemented, but {{Peek()}} is a standard functionality for all Thrift transports. Throughout the library the core concepts and the implementations should be as consistent as possible. Even though {{Peek()}} is not listed [here|https://thrift.apache.org/docs/concepts] (note that the list is marked as not exhaustive), IMHO making it better => yes, removing => no. @all: Other opinions welcome, though. was (Author: jensg): {quote} If there are useless, we can remove them right? {quote} It may not be the best way how it is implemented, but {{Peek()}} is a standard functionality for all Thrift transports. Even though it is not listed [here|https://thrift.apache.org/docs/concepts] (note that the list is marked as not exhaustive), IMHO making it better => yes, removing => no. @all: Other opinions welcome, though. > Remove strange public Peek() from GO transports > ----------------------------------------------- > > Key: THRIFT-2851 > URL: https://issues.apache.org/jira/browse/THRIFT-2851 > Project: Thrift > Issue Type: Bug > Components: Go - Library > Affects Versions: 0.9.2 > Reporter: Chi Vinh Le > Priority: Minor > Fix For: 0.9.3 > > > I've been seeing this public Peek() function in the GO library for a while, > but > still cannot figure out any sense to it. > If there are useless, we can remove them right? > This PR removes the public Peek() from the implemented transports. > All tests still pass. > PR: https://github.com/apache/thrift/pull/283 -- This message was sent by Atlassian JIRA (v6.3.4#6332)