[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231438#comment-14231438
]
Randy Abernethy commented on THRIFT-2844:
-----------------------------------------
Hey Cam,
Thanks for the Browserify education. I suppose if Node.js ever develops an
interface conflict with Browserify responseType there will be plenty of people
raising the issue. I'll add the code that forwards the responseType on back in
and commit the patch.
Best,
Randy
> Nodejs support broken when running under Browserify
> ---------------------------------------------------
>
> Key: THRIFT-2844
> URL: https://issues.apache.org/jira/browse/THRIFT-2844
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Affects Versions: 0.9.2
> Environment: Browserify
> Reporter: Cameron Ring
> Assignee: Randy Abernethy
> Attachments: 0001-browserify-update-for-ArrayBuffer.patch
>
>
> When running under Browserify, the NodeJS binding fails when using the HTTP
> transport. This happens because Browserify is returning the response as a
> Uint8Array rather than a Buffer. The fix is straightforward: in
> response.on('data', wrap any Uint8Arrays in a buffer so the types are as
> expected.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
