[ 
https://issues.apache.org/jira/browse/THRIFT-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235419#comment-14235419
 ] 

ASF GitHub Bot commented on THRIFT-2859:
----------------------------------------

GitHub user stigsb opened a pull request:

    https://github.com/apache/thrift/pull/305

    JSON generator: don't use long when writing i64

    This should hopefully fix issues in THRIFT-2859 for platforms with 32-bit 
long.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stigsb/thrift json_generator_int_overflow_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/305.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #305
    
----
commit 99e619d7d0272f8cbeb7c3357f5480aade507773
Author: Stig Bakken <s...@zedge.net>
Date:   2014-12-05T10:33:04Z

    JSON generator: don't use long when writing i64

----


> JSON generator: output complete descriptors
> -------------------------------------------
>
>                 Key: THRIFT-2859
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2859
>             Project: Thrift
>          Issue Type: Improvement
>          Components: JSON - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Stig Bakken
>            Assignee: Jens Geyer
>            Priority: Minor
>             Fix For: 0.9.3
>
>
> (Someone should probably add a Jira component for the JSON generator.)
> The attached pull request contains some improvements to the JSON generator:
> 1. programs are no longer merged by default, use "--gen json:merge"
> 2. "index" is renamed to "key" for fields to match the compiler's internal 
> naming
> 3. types are described in a way that does not require string parsing
> 4. full support for exceptions, unions, namespaces, includes and 
> required/optional fields



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to