[ 
https://issues.apache.org/jira/browse/THRIFT-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239128#comment-14239128
 ] 

ASF GitHub Bot commented on THRIFT-2879:
----------------------------------------

Github user winsweet closed the pull request at:

    https://github.com/apache/thrift/pull/308


> TMemoryBuffer: using lua string in wrong way
> --------------------------------------------
>
>                 Key: THRIFT-2879
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2879
>             Project: Thrift
>          Issue Type: Bug
>          Components: Lua - Library
>            Reporter: winsweet
>            Assignee: Roger Meier
>
> 1. 
> local val = string.sub(self.buffer, self.rPos, len)
> The call string.sub(s,i,j) extracts a piece of the string s, 
> from the i-th to the j-th character inclusive. 
> In Lua, the first character of a string has index 1.
> 2.
> self.buffer = self.buffer + buf
> self.wPos = self.wPos + buf
> .. is the string concatenation operator in Lua, not +.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to