[
https://issues.apache.org/jira/browse/THRIFT-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stig Bakken reopened THRIFT-2894:
---------------------------------
Hi Jens,
I updated (and squashed) the original pull request, the commit you merged did
not handle enums correctly. This is the fixed commit:
https://github.com/stigsb/thrift/commit/5914cf3c5c552c8d7641add4e596884ce2c59da4
> PHP json serializer skips maps with int/bool keys
> -------------------------------------------------
>
> Key: THRIFT-2894
> URL: https://issues.apache.org/jira/browse/THRIFT-2894
> Project: Thrift
> Issue Type: Bug
> Components: PHP - Compiler
> Affects Versions: 0.9.2
> Reporter: Stig Bakken
> Assignee: Jens Geyer
> Priority: Minor
> Fix For: 0.9.3
>
>
> When the PHP generator runs with the "json" option, it skips fields that are
> maps with non-string keys. An instance of this struct will produce an empty
> object when JSON-serialized:
> {code}struct Foo {
> 1: map<i32,string>;
> }{code}
> This is unnecessarily strict, since PHP's json_encode() function will convert
> the keys to strings for you.
> Pull request coming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
