[ 
https://issues.apache.org/jira/browse/THRIFT-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252266#comment-14252266
 ] 

Hudson commented on THRIFT-2894:
--------------------------------

SUCCESS: Integrated in Thrift #1407 (See 
[https://builds.apache.org/job/Thrift/1407/])
THRIFT-2894 PHP json serializer skips maps with int/bool keys (jensg: rev 
c61b3a8170e0decf2a4e863c89bf34acc16b0363)
* compiler/cpp/src/generate/t_php_generator.cc


> PHP json serializer skips maps with int/bool keys
> -------------------------------------------------
>
>                 Key: THRIFT-2894
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2894
>             Project: Thrift
>          Issue Type: Bug
>          Components: PHP - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Stig Bakken
>            Assignee: Jens Geyer
>            Priority: Minor
>             Fix For: 0.9.3
>
>
> When the PHP generator runs with the "json" option, it skips fields that are 
> maps with non-string keys. An instance of this struct will produce an empty 
> object when JSON-serialized:
> {code}struct Foo {
>   1: map<i32,string>;
> }{code}
> This is unnecessarily strict, since PHP's json_encode() function will convert 
> the keys to strings for you.
> Pull request coming.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to