[
https://issues.apache.org/jira/browse/THRIFT-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254244#comment-14254244
]
ASF GitHub Bot commented on THRIFT-2907:
----------------------------------------
GitHub user jparise opened a pull request:
https://github.com/apache/thrift/pull/334
Don't define ntohll() if it is already defined.
Fixes [THRIFT-2907](https://issues.apache.org/jira/browse/THRIFT-2907)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jparise/thrift thrift-2907
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/334.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #334
----
commit 68cc8358b14d184bb5faac4faca7ea9d5b0ce308
Author: Jon Parise <j...@pinterest.com>
Date: 2014-12-19T23:32:24Z
Don't define ntohll() if it is already defined.
Fixes THRIFT-2907
----
> 'ntohll' macro redefined
> ------------------------
>
> Key: THRIFT-2907
> URL: https://issues.apache.org/jira/browse/THRIFT-2907
> Project: Thrift
> Issue Type: Bug
> Components: Build Process
> Affects Versions: 0.9.2
> Environment: Apple LLVM version 6.0 (clang-600.0.54) (based on LLVM
> 3.5svn)
> Target: x86_64-apple-darwin14.0.0
> Thread model: posix
> Reporter: Jon Parise
> Priority: Trivial
>
> The {{ntohll}} macro is already defined in {{/usr/include/sys/_endian.h}} on
> Mac OS X.
> {code}
> In file included from gen-cpp/shared_constants.cpp:7:
> In file included from gen-cpp/shared_constants.h:10:
> In file included from gen-cpp/shared_types.h:14:
> ../../lib/cpp/src/thrift/protocol/TProtocol.h:131:11: warning: 'ntohll' macro
> redefined
> # define ntohll(n) ( (((uint64_t)ntohl((uint32_t)n)) << 32) +
> ntohl((uint32_t)(n >> 32)) )
> ^
> /usr/include/sys/_endian.h:140:9: note: previous definition is here
> #define ntohll(x) __DARWIN_OSSwapInt64(x)
> ^
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
