GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/341
THRIFT-2886 Integrate binary type in standard Thrift cross testï For reasons of better maintainability, this PR consists of 5 commits: - adding testBinary to the ThriftTest.thrift IDL file - adding full testBinary() support to Delphi - adding full testBinary() support to C# - adding full testBinary() support to Haxe - adding **partial** testBinary() support to: - C_glib - C++ - D - Erlang - Go - Haskell - Lua - Java/Me - JavaScript - Node - Ocaml - Perl - PHP - Python - Ruby The latter are minimal, server-side implementations only to just satisfy `make check`. There have been a number of TODOs added to the sources, these should be solved by subsequent tickets. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift thrift-2886-testBinary Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/341.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #341 ---- commit 0d1adeca528f3644162ad56451db8f0873f09641 Author: Jens Geyer <je...@apache.org> Date: 2014-12-13T22:39:45Z THRIFT-2886 Integrate binary type in standard Thrift cross test Client: Tests Patch: Jens Geyer commit da1d3461f2124031f638d1848f0a536f8cc4a585 Author: Jens Geyer <je...@apache.org> Date: 2014-12-13T22:40:35Z THRIFT-2886 Integrate binary type in standard Thrift cross test Client: C# Patch: Jens Geyer commit 2c7e4f423f39f11a46a572dd70082992f8a30030 Author: Jens Geyer <je...@apache.org> Date: 2014-12-13T22:42:58Z THRIFT-2886 Integrate binary type in standard Thrift cross test Client: Delphi Patch: Jens Geyer commit e2142a4cb867fb5ef8db4f90ed9f129707fa9bd7 Author: Jens Geyer <je...@apache.org> Date: 2014-12-13T23:29:17Z THRIFT-2886 Integrate binary type in standard Thrift cross test Client: Haxe Patch: Jens Geyer commit 1886873e376b2dcd8b1c24fb3fd0eb2dc47f0c69 Author: Jens Geyer <je...@apache.org> Date: 2014-12-14T02:14:26Z THRIFT-2886 Integrate binary type in standard Thrift cross test Client: C_glib, C++, D, Erlang, Go, Haskell, Lua, Java/Me, JavaScript, Node, Ocaml, Perl, PHP, Python, Ruby Patch: Jens Geyer Minimal server-side implementations and TODO stubs for various languages to let "make check" succeeed. Not contained in this patch and still TODO: - client side implementations, i.e. calls to testBinary() and appropriate tests - server side hex printout missing for some languages ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---