[ 
https://issues.apache.org/jira/browse/THRIFT-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264656#comment-14264656
 ] 

ASF GitHub Bot commented on THRIFT-2925:
----------------------------------------

Github user nsuke commented on the pull request:

    https://github.com/apache/thrift/pull/344#issuecomment-68719977
  
    Merged as c444fb581d2157c260f36db091a7cdd4511c6e32, thanks :)


> CMake build does not work with OpenSSL nor anything installed in non-system 
> location
> ------------------------------------------------------------------------------------
>
>                 Key: THRIFT-2925
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2925
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process, C++ - Library
>            Reporter: Nobuaki Sukegawa
>            Assignee: Nobuaki Sukegawa
>
> It's caused by many incorrect CMake variable names.
> Examples of correct variable names:
> * LIBEVENT_INCLUDE_DIRS
> * OPENSSL_INCLUDE_DIR (without S !!)
> * Boost_INCLUDE_DIRS (not BOOST !!)
> It is almost funny how these variable names are inconsistent, nonetheless 
> correct names should be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to