[ 
https://issues.apache.org/jira/browse/THRIFT-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14266586#comment-14266586
 ] 

Roger Meier commented on THRIFT-2926:
-------------------------------------

hey guys, please check this: https://github.com/ariya/phantomjs/issues/10476
setting these environment variables fixed the issue:
{noformat}
export LC_ALL=en_US.UTF-8
export LANG=en_US.UTF-8
export LANGUAGE=en_US.UTF-8
{noformat}

the other thing I had in mind is defining a constant within 
test/ThriftTest.thrift containing the UTF-8 test data we use here 
https://github.com/apache/thrift/blob/master/lib/js/test/test.js#L55

best!
-roger

> JavaScript: binary protocol implementation
> ------------------------------------------
>
>                 Key: THRIFT-2926
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2926
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: JavaScript - Library
>    Affects Versions: 0.9.2
>            Reporter: Radoslaw Gruchalski
>            Assignee: Randy Abernethy
>              Labels: features, javascript
>
> I have implemented BinaryProtocol for the JS library. Implementation provided 
> with unit tests. Looking for feedback.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to