[ 
https://issues.apache.org/jira/browse/THRIFT-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267021#comment-14267021
 ] 

Roger Meier commented on THRIFT-1854:
-------------------------------------

I'm fine with this as long as it is only a compiler option.
The only thing I would change befor committing this is:
{noformat}
-"    trove_lists:     Use Trove array lists where possible instead of Java 
native collections.\n"
+"    trove_lists:     Use GNU Trove(net.sf.trove4j) array lists where possible 
instead of Java native collections.\n"
{noformat}

any concerncs?



> trove support for lists of primitives
> -------------------------------------
>
>                 Key: THRIFT-1854
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1854
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Java - Compiler
>            Reporter: Vitali Lovich
>         Attachments: 
> 0001-adding-support-to-use-Trove-0.9-lists-for-lists.patch, 
> 0001-adding-support-to-use-Trove-0.9.2-lists-for-lists.patch, 
> 0001-adding-support-to-use-Trove-lists-for-lists.patch
>
>
> When dealing with large collections of primitive types, there can be 
> significant memory (i.e. using arrays of objects instead of arrays of 
> primitives) & runtime overhead (autoboxing/unboxing) using the default 
> collections.  Utilizing trove can significantly improve things.  ideally 
> support would be added for sets & maps, but as a first pass lists would be 
> great.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to