GitHub user sh1mmer opened a pull request:
https://github.com/apache/thrift/pull/349
Pass error through callback
Injects the seqid to allow the connection to reference the callback and
then associates as many request specific errors with the callback as possible.
Also wraps the callback so that it only fires once.
TODOs logging, more unit tests
I need to find an a better unit testing library for Node that is Apache 2.0
compatible (e.g. upstreamable).
cc @Raynos @kriskowal @sectioneight @breerly @willyham
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uber/thrift safety
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/349.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #349
----
commit 9b8b94bcd9dfb31e40f9f3a300f844135a8e2c6f
Author: Tom Croucher <t...@uber.com>
Date: 2015-01-02T23:13:01Z
Add notes to http conn
commit 9ee5e9011d340bf9c3226a9352226ec9a179af89
Author: Tom Croucher <t...@uber.com>
Date: 2015-01-09T20:39:53Z
Wrap calls to force errors to callback
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
