Github user bufferoverflow commented on the pull request:

    https://github.com/apache/thrift/pull/345#issuecomment-69494103
  
    Thanks @radekg for this udate.
    
    any idea about the jslint issues?
    
        cd lib/js/test
        make check
        lib/js/test/build.xml:216: JSLint: 39 errors in 1 file
    
    They might be related to the unit test issues:
    ```
    cd lib/js/test
    ant unittest
    ...
    unittest:
         [echo] Running Unit Tests with headless browser!
         [exec] Xlib:  extension "RANDR" missing on display ":99".
         [java] Timeout: killed the sub-process
         [java] Java Result: -1
         [exec] 'waitFor()' finished in 403ms.
         [exec] Tests completed in 267 milliseconds.
         [exec] 4 assertions of 41 passed, 37 failed.
    ```
    
    You can also remove ThriftTest.thrift file from this commit it is a 
duplication.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to