[
https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291355#comment-14291355
]
Andrew de Andrade commented on THRIFT-2940:
-------------------------------------------
I would love to see the javascript thrift stuff pull out as an entirely
separate repo. This one massive repo thing is just awkward. The main repo could
include the npm repo as a git subtree. The node client is not node-like in so
many ways. Making the node client available in a more standard way would make
it far easier for those of us that are NodeJS developers to more effectively
contribute to the NodeJS client (and the browser JavaScript client). I'm not
even sure how to get started because I don't know how the NodeJS client relates
to the browser JavaScript client. I would expect that they must share some
code, but it's not clear that there is any DRY way that they do or if similar
parts are just copypasta-ed from one to the other or if there is some build
step.
+1 for a package.json in the root folder in the meantime. There needs to be
someway to more effectively work from your own fork than the current approach.
This is crucial to get more contributions from NodeJS developers. Having a way
to use thrift with Browserify is another (the thrift client uses globals via
window.Thrift)
> Allow installing Thrift from git as NPM module by providing package.json in
> top level directory
> -----------------------------------------------------------------------------------------------
>
> Key: THRIFT-2940
> URL: https://issues.apache.org/jira/browse/THRIFT-2940
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Reporter: Radoslaw Gruchalski
>
> Allow installing thirft from git as NPM module by providing package.json in
> top level directory. Currently, result is similar to:
> {noformat}
> drone:gossiperl-client-js rad$ npm install
> npm WARN excluding symbolic link tutorial/erl/client.sh -> server.sh
> npm ERR! Error: ENOENT, open
> '/var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json'
> npm ERR! If you need help, you may report this log at:
> npm ERR! <http://github.com/isaacs/npm/issues>
> npm ERR! or email it to:
> npm ERR! <[email protected]>
> npm ERR! System Darwin 14.0.0
> npm ERR! command "node" "/usr/local/bin/npm" "install"
> npm ERR! cwd /Users/rad/dev/my/gossiperl-client-js
> npm ERR! node -v v0.10.22
> npm ERR! npm -v 1.3.14
> npm ERR! path
> /var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json
> npm ERR! code ENOENT
> npm ERR! errno 34
> npm ERR!
> npm ERR! Additional logging details can be found in:
> npm ERR! /Users/rad/dev/my/gossiperl-client-js/npm-debug.log
> npm ERR! not ok code 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
