[
https://issues.apache.org/jira/browse/THRIFT-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299986#comment-14299986
]
Andrew de Andrade edited comment on THRIFT-2959 at 1/31/15 8:59 PM:
--------------------------------------------------------------------
I ran `npm test` before every commit using the vagrantfile setup on ubuntu
trusty64, so it's strange that the tests don't pass for you.
There should always be two ways to access the binfile with nodejs. The one you
mentioned is where the binary actually lives. However npm also puts symlinks
for binaries for top level modules (i.e. not nested modules) in the
../node_modules/.bin/ folder.
Thus, the nodeunit binary lives where you said it does
(../node_modules/nodeunit/bin/nodeunit), but there is also a symlink in the
../node_modules/.bin
{{../node_modules/.bin/nodeunit --> ../node_modules/nodeunit/bin/nodeunit}}
Can you confirm that nodeunit is in that ((.bin)) folder?
was (Author: andrewdeandrade):
I ran `npm test` before every commit using the vagrantfile setup on ubuntu
trusty64, so it's strange that the tests don't pass for you.
There should always be two ways to access the binfile with nodejs. The one you
mentioned is where the binary actually lives. However npm also puts symlinks
for binaries for top level modules (i.e. not nested modules) in the
../node_modules/.bin/ folder.
Thus, the nodeunit binary lives where you said it does
(../node_modules/nodeunit/bin/nodeunit), but there is also a symlink in the
../node_modules/.bin
{{../node_modules/.bin/nodeunit --> ../node_modules/nodeunit/bin/nodeunit}}
> nodejs: fix binary unit tests
> -----------------------------
>
> Key: THRIFT-2959
> URL: https://issues.apache.org/jira/browse/THRIFT-2959
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Environment: Trusty64 Vagrant Box
> Reporter: Andrew de Andrade
> Priority: Minor
> Attachments: thrift-2959-nodejs-fix-binary-unit-tests.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
