[
https://issues.apache.org/jira/browse/THRIFT-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14300066#comment-14300066
]
Randy Abernethy commented on THRIFT-2959:
-----------------------------------------
Hey Andrew,
--no-bin-links was required to get the Vagrant config working. Thrift is
accessed from the guest using a shared host folder (the thrift repo where the
contrib vagrantfile is located) which appears as a fs that doesn't support
symlinks. Several problems with npm arise in the vagrant guest when this is not
set. There may be other ways to skin the cat. If you can get the Vagrant build
to take without --no-bin-links I'm all for it. Otherwise maybe the full path is
the lowest hanging fruit.
Another reason to avoid digressing too far into the configuration management of
all this is that it looks as if Thrift will be moving to CMake in the not too
distant future. Also Docker is showing up as a faster, and in some ways more
robust way to test Thrift, so Vagrant may be less important down the road (or
important as a container provisioner rather than a VM provisioner).
Will your patches apply with the double patch committed?
-Randy
> nodejs: fix binary unit tests
> -----------------------------
>
> Key: THRIFT-2959
> URL: https://issues.apache.org/jira/browse/THRIFT-2959
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library
> Environment: Trusty64 Vagrant Box
> Reporter: Andrew de Andrade
> Priority: Minor
> Attachments:
> 0001-npm-install-adds-bin-links-to-node_modules-.bin.patch,
> thrift-2959-nodejs-fix-binary-unit-tests.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
