[
https://issues.apache.org/jira/browse/THRIFT-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randy Abernethy updated THRIFT-2934:
------------------------------------
Attachment: 0001-make-options-optional-again-in-node-server.patch
patch
> createServer signature mismatch
> -------------------------------
>
> Key: THRIFT-2934
> URL: https://issues.apache.org/jira/browse/THRIFT-2934
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Library, Tutorial
> Affects Versions: 0.9.2
> Reporter: Alan Cheung
> Priority: Trivial
> Attachments: 0001-make-options-optional-again-in-node-server.patch
>
>
> The nodejs example https://thrift.apache.org/tutorial/nodejs
> If we createServer without a third option argument, would result in
> if (options.tls) {
> ^
> TypeError: Cannot read property 'tls' of undefined
> at Object.exports.createMultiplexServer
> (...\ProjRoot\node_modules\thrift\lib\thrift\s
> erver.js:89:14)
> at Object.exports.createServer
> (...\ProjRoot\node_modules\thrift\lib\thrift\server.js:106:18)
> at Object.<anonymous> (...\ProjRoot\NodeServer.js:8:21)
> at Module._compile (module.js:456:26)
> at Object.Module._extensions..js (module.js:474:10)
> at Module.load (module.js:356:32)
> at Function.Module._load (module.js:312:12)
> at Function.Module.runMain (module.js:497:10)
> at startup (node.js:119:16)
> at node.js:929:3
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
