[
https://issues.apache.org/jira/browse/THRIFT-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301679#comment-14301679
]
Andrew de Andrade commented on THRIFT-2967:
-------------------------------------------
There is one big caveat for when each language decides to enable .editorconfig
for their language file extensions: Many .editorconfig plugins will
automatically fix white spaces issues, such as converting tabs to spaces,
trimming trailing whitespace characters and ensuring a newline at the end of
files.
The reason this is important is that we may want to adopt a procedure that
whenever editorconfig is enabled for a particular extension, that all files
with that extension are cleaned up (reindented, etc.) in the same or subsequent
commit. The reason this matters is that a LOT of lines might change depending
how inconsistent a file was before being saved with an .editorconfig plugin
enabled. It's going to be much easier to handle merging enabling of
.editorconfig if it's against master only and there are only whitespace changes
(tests should still pass).
> Add .editorconfig to root
> -------------------------
>
> Key: THRIFT-2967
> URL: https://issues.apache.org/jira/browse/THRIFT-2967
> Project: Thrift
> Issue Type: Improvement
> Reporter: Andrew de Andrade
> Priority: Trivial
> Attachments: 0001-Adding-.editorconfig-file-to-root.patch
>
>
> [.editorconfig files|http://editorconfig.org] allow most (if not all major)
> text editors to auto config certain settings like hard tabs vs soft tabs and
> tab length.
> Going through the thrift codebase, indentation size and style is wildly
> inconsistent from language to language. Using .editorconfig will help
> mitigate these problems. The commiters of each language should consider
> configuring editorconfig settings for the thrift code for their language.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
