[ 
https://issues.apache.org/jira/browse/THRIFT-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14302738#comment-14302738
 ] 

Randy Abernethy commented on THRIFT-2962:
-----------------------------------------

Hey Jake,

Just checked this out. I tried it on Windows with the vagrant file and on an 
Ubuntu 14.04 box. 

Results:
 - 6 white space errors in the patch
 - make
     * Neither would make with Haxe enabled
     * Without Haxe both make
 - make check
     * The Windows box runs out of RAM (the vagrantfile sets the Ubuntu host to 
1GB)
     * The Ubuntu box (8GB RAM) seg faults during the TNonblockingServerTest 
(this is probably broken anyway)

This is related to Ervin Varga's THRIFT-2623 patch.  Noticed there are several 
thrift containers on docker hub. Ervin's has been up there for a while. Also 
ahawkins/docker-thrift has a docker hub "official repo" thrift container for 
just running a pre built compiler on thrift files (pretty cool and current). 
Roger's make cross container is up there as well.

Anyway, awesome stuff. I would really be supportive of any singular reference 
environment we could all use to ensure that tests are passing and CI is 
building clean. 

-Randy

> Docker Thrift env for development and testing
> ---------------------------------------------
>
>                 Key: THRIFT-2962
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2962
>             Project: Thrift
>          Issue Type: Bug
>            Reporter: Jake Farrell
>            Assignee: Jake Farrell
>             Fix For: 0.9.3
>
>         Attachments: THRIFT-2962.patch
>
>
> Create a dockerfile for testing all components of Apache Thrift in Ubuntu and 
> Centos containers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to