[
https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304786#comment-14304786
]
Andrew de Andrade commented on THRIFT-2940:
-------------------------------------------
I imagine the cross test will stay the way it is, however, I would love it if
the way it's executed was inverted. i.e. instead of having one cross test that
runs all the cross tests, you'd have a cross test per language that runs all
the cross tests per language.
My reasoning here is that when I make a change to the nodejs code, I want to
run all the cross tests with nodejs versus every other implementation. I don't
necessarily care (nor should I worry that two implementations whose code I
haven't touched don't currently work together).
Making it easier and faster to run the cross tests that you might have broken
with your changes is going to increase the likelihood that people check them
before committing.
Obviously this will require quite a bit of work, but it's worthwhile for the
long term IMHO.
> Allow installing Thrift from git as NPM module by providing package.json in
> top level directory
> -----------------------------------------------------------------------------------------------
>
> Key: THRIFT-2940
> URL: https://issues.apache.org/jira/browse/THRIFT-2940
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Reporter: Radoslaw Gruchalski
> Assignee: Roger Meier
>
> Allow installing thirft from git as NPM module by providing package.json in
> top level directory. Currently, result is similar to:
> {noformat}
> drone:gossiperl-client-js rad$ npm install
> npm WARN excluding symbolic link tutorial/erl/client.sh -> server.sh
> npm ERR! Error: ENOENT, open
> '/var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json'
> npm ERR! If you need help, you may report this log at:
> npm ERR! <http://github.com/isaacs/npm/issues>
> npm ERR! or email it to:
> npm ERR! <[email protected]>
> npm ERR! System Darwin 14.0.0
> npm ERR! command "node" "/usr/local/bin/npm" "install"
> npm ERR! cwd /Users/rad/dev/my/gossiperl-client-js
> npm ERR! node -v v0.10.22
> npm ERR! npm -v 1.3.14
> npm ERR! path
> /var/folders/gd/jkx3kmg53gj85lwjslf79n6m0000gn/T/npm-36445-mmwd9VRJ/1421011402511-0.04021586640737951/package/package.json
> npm ERR! code ENOENT
> npm ERR! errno 34
> npm ERR!
> npm ERR! Additional logging details can be found in:
> npm ERR! /Users/rad/dev/my/gossiperl-client-js/npm-debug.log
> npm ERR! not ok code 0
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
