GitHub user pjjw opened a pull request:

    https://github.com/apache/thrift/pull/380

    add go json annotation 'omitempty' on optionals

    if a field is optional, we shouldn't need to assert its nullness when
    serializing to json. this additionally matches protobuf behavior.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pjjw/thrift THRIFT-3006

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/380.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #380
    
----
commit b5dba4618c1993603e9c5ec15b50e16da00eb394
Author: Peter Woodman <pe...@vineapp.com>
Date:   2015-02-21T01:31:04Z

    add go json annotation 'omitempty' on optionals
    
    if a field is optional, we shouldn't need to assert its nullness when
    serializing to json. this additionally matches protobuf behavior.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to