[ 
https://issues.apache.org/jira/browse/THRIFT-3024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14349664#comment-14349664
 ] 

ASF GitHub Bot commented on THRIFT-3024:
----------------------------------------

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/390

    THRIFT-3024 User-Agent "BattleNet" used in some Thrift library files

    Client: AS3, Haxe
    Patch: Jens Geyer

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift THRIFT-3024-useragent

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/390.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #390
    
----
commit d5de49ec3b4aefc3aef5a1044b85bfe78a08b21d
Author: Jens Geyer <[email protected]>
Date:   2015-03-05T22:59:05Z

    THRIFT-3024 User-Agent "BattleNet" used in some Thrift library files
    Client: AS3, Haxe
    Patch: Jens Geyer

----


> User-Agent "BattleNet" used in some Thrift library files
> --------------------------------------------------------
>
>                 Key: THRIFT-3024
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3024
>             Project: Thrift
>          Issue Type: Bug
>          Components: AS3 - Library, Haxe - Library
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Minor
>              Labels: useragent
>             Fix For: 0.9.3
>
>
> Both the AS3 and the (derived) Haxe library use the string {{User-Agent: 
> BattleNet}}. Although there is no 100% consistent schema how a Thrift user 
> agent string should exactly look like, this one seems clearly wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to