[ 
https://issues.apache.org/jira/browse/THRIFT-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351568#comment-14351568
 ] 

ASF GitHub Bot commented on THRIFT-3023:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/389


> Go compiler is a little overly conservative with names of attributes
> --------------------------------------------------------------------
>
>                 Key: THRIFT-3023
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3023
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler
>    Affects Versions: 0.9.2
>            Reporter: Paul Magrath
>            Assignee: Jens Geyer
>
> Go compiler, in attempting to avoid using variable names that are reserved 
> words in Go, is being a little overly conservative. 
> For example, if you have a struct like this:-
> {code}
> struct NamesTest {
>               1: required string type
> }
> {code}
> One would expect it to compile to:-
> {code}
> type NamesTest struct {
>       Type string `thrift:"type,1,required" json:"type"`
> }
> {code}
> Rather than:-
> {code}
> type NamesTest struct {
>       TypeA1 string `thrift:"type,1,required" json:"type"`
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to