[
https://issues.apache.org/jira/browse/THRIFT-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14361837#comment-14361837
]
Hudson commented on THRIFT-3027:
--------------------------------
SUCCESS: Integrated in Thrift #1474 (See
[https://builds.apache.org/job/Thrift/1474/])
THRIFT-3027 Go compiler does not ensure common initialisms have consistent case
(jensg: rev 1d1bca2738febb87bf132d041a73cd8da5a6328b)
* lib/go/test/Makefile.am
* lib/go/test/tests/initialisms_test.go
* compiler/cpp/src/generate/t_go_generator.cc
* lib/go/test/InitialismsTest.thrift
> Go compiler does not ensure common initialisms have consistent case
> -------------------------------------------------------------------
>
> Key: THRIFT-3027
> URL: https://issues.apache.org/jira/browse/THRIFT-3027
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler
> Affects Versions: 0.9.2
> Reporter: Paul Magrath
> Assignee: Jens Geyer
> Priority: Minor
> Fix For: 0.9.3
>
>
> In Go, as per
> https://github.com/golang/go/wiki/CodeReviewComments#initialisms, words in
> names that are initialisms or acronyms should have a consistent case.
> For example, if you have a struct like:
> {code}
> struct InitialismsTest {
> 1: string user_id,
> 2: string server_url,
> }
> {code}
> One would expect it to compile to:
> {code}
> type InitialismsTest struct {
> UserID string `thrift:"user_id,1" json:"user_id"`
> ServerURL string `thrift:"server_url,2" json:"server_url"`
> }
> {code}
> Rather than:-
> {code}
> type InitialismsTest struct {
> UserId string `thrift:"user_id,1" json:"user_id"`
> ServerUrl string `thrift:"server_url,2" json:"server_url"`
> }
> {code}
> It would be pretty difficult to handle all cases of initialisms in the Go
> compiler of course, but there is a set of common initialisms that have been
> identified by the authors of Golint and could be handled relatively easily:-
> https://github.com/golang/lint/blob/master/lint.go#L692
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
