[
https://issues.apache.org/jira/browse/THRIFT-3041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368104#comment-14368104
]
Mike Riley commented on THRIFT-3041:
------------------------------------
I think for the sake of consistency I'm going to leave the ivars as they are
(unless Jake objects) so that they can get updated alongside the rest of the
library if THRIFT-2982 goes through. I'm looking into your suggestion about
get_extends, however I'm wondering whether it's also better to just leave it as
is for the sake of consistency again.
I'd be happy to look into "modernizing" all of the code at once if there is
some support for doing so, I ran across a bunch of things that could be a
little better handled when I was coming up with this patch.
Jake: I actually still have some pending updates to this patch because I found
some formatting issues I introduced in to the generated code.
> Generate asynchronous clients for Cocoa
> ---------------------------------------
>
> Key: THRIFT-3041
> URL: https://issues.apache.org/jira/browse/THRIFT-3041
> Project: Thrift
> Issue Type: Improvement
> Components: Cocoa - Compiler, Cocoa - Library
> Reporter: Mike Riley
> Fix For: 0.9.3
>
> Attachments: async-clients.diff
>
>
> I've been using thrift on a decent variety of iOS projects for the last ~4
> years. Every time I set a new project up, I invariably end up inventing some
> way to invoke thrift RPC calls via Objective-C block syntax. I usually end
> up ripping apart the generated classes by declaring their private methods,
> and then writing a bunch of boilerplate all so that I can avoid using the
> provided HTTP client, which makes synchronous requests.
> This is a decent stab at letting the generator take care of this problem for
> me, and everyone else. It ended up being pretty heavy handed with
> t_cocoa_generator.cc, but I've spent a while testing this and am pretty
> confident I managed to avoid breaking anything. I realize this is a large
> change, so I've put up the sandbox I was using to test on github if that
> makes it easier to review. If you want the tl;dr; about what practical
> changes this has on generated sources:
> https://github.com/yelirekim/thrift-cocoa-love/blob/master/thrift-cocoa-love/ViewController.m
> https://github.com/yelirekim/thrift-cocoa-love/blob/master/gen-cocoa/asdf.h
> I'd welcome feedback or proposed modifications if this approach isn't quite
> right.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
