[ https://issues.apache.org/jira/browse/THRIFT-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378768#comment-14378768 ]
Hudson commented on THRIFT-847: ------------------------------- SUCCESS: Integrated in Thrift #1482 (See [https://builds.apache.org/job/Thrift/1482/]) THRIFT-847 Test Framework harmonization across all languages (roger: rev 41ad4342c5a0389ab2cf2dbf098086413ac01204) * test/cpp/Makefile.am * test/haxe/Makefile.am * test/go/src/common/server.go * test/c_glib/Makefile.am * test/go/Makefile.am * test/crossrunner/__init__.py * lib/Makefile.am * lib/java/Makefile.am * test/crossrunner/test.py * lib/csharp/test/ThriftTest/Makefile.am * test/crossrunner/report.py * test/php/Makefile.am * lib/go/Makefile.am * test/py.twisted/Makefile.am * lib/csharp/Makefile.am * test/tests.json * test/result.html * test/Makefile.am * lib/nodejs/Makefile.am * .travis.yml * test/php/TestClient.php * lib/go/test/Makefile.am * test/crossrunner/collect.py * test/hs/Makefile.am * test/perl/Makefile.am * lib/haxe/test/Makefile.am * test/py/Makefile.am * test/known_failures_Linux.json * test/go/src/bin/testserver/main.go * test/perl/TestClient.pl * lib/csharp/test/ThriftTest/Program.cs * test/go/src/common/clientserver_test.go * configure.ac * test/test.py * Makefile.am * test/rb/Makefile.am * lib/csharp/test/ThriftTest/TestServer.cs * test/crossrunner/run.py * lib/csharp/test/ThriftTest/TestClient.cs * test/crossrunner/util.py * .gitignore * test/erl/Makefile.am * test/crossrunner/prepare.py > Test Framework harmonization across all languages > ------------------------------------------------- > > Key: THRIFT-847 > URL: https://issues.apache.org/jira/browse/THRIFT-847 > Project: Thrift > Issue Type: Improvement > Components: C# - Library, C++ - Library, Cocoa - Library, Erlang - > Library, Haskell - Library, Java - Library, JavaScript - Library, OCaml - > Library, Perl - Library, PHP - Library, Python - Library, Ruby - Library, > Test Suite > Affects Versions: 0.1, 0.2, 0.3 > Reporter: Roger Meier > Assignee: Roger Meier > Labels: gsoc2014, mentor > Attachments: > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > 0001-THRIFT-847-Test-Framework-harmonization-across-all-l.patch, > THRIFT-847_add__make_cross__build_target.patch, build.xml, test.sh, > v1-WORK_IN_PROGRESS-unified_tests.tar.gz > > > Today each Language supported by Thrift, have its own unit test, all are > using the same Thrift IDL's located at the test directory. But the behavior > of these tests seems to be different from language to language... this makes > it difficult to do tests and bug fixing across different Languages. e.g. > * C++ Test and JavaScript Test Server written in Java have different > responses for the same services > * C# and Java Test Server have different responses for testException as C++ > I propose the following steps: > * identify the language with the reference implementation (well defined > return values for all test cases) > * update the ThriftTest.thrift with details about the required return values > that have to be implemented > * update test implementations and move language tests into their appropriate > library directory (THRIFT-35) > * a public test server that supports multiple protocols and transports could > be another enhancement for testing purposes > I'm ready to help preparing patches, just tell me what you need! -- This message was sent by Atlassian JIRA (v6.3.4#6332)