[
https://issues.apache.org/jira/browse/THRIFT-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14380790#comment-14380790
]
deepankar edited comment on THRIFT-2157 at 3/25/15 9:23 PM:
------------------------------------------------------------
I dont think TException should implement TBase as some times (most of the
times) it is thrown directly on the client side for errors in the client
calling. It is better to keep it separate. Also TBase represents an
serializable message, but where as TException is a generic exception and does
not necessarily need to be written to a wire.
was (Author: dvdreddy):
Now I see, it make sense for TApplicationException implement TBase.
I dont think TException should implement TBase as some times (most of the
times) it is thrown directly on the client side for errors in the client
calling. It is better to keep it separate. Also TBase represents an
serializable message, but where as TException is a generic exception and does
not necessarily need to be written to a wire.
> generated code would cause ClassCastException
> ---------------------------------------------
>
> Key: THRIFT-2157
> URL: https://issues.apache.org/jira/browse/THRIFT-2157
> Project: Thrift
> Issue Type: Bug
> Components: Java - Compiler
> Affects Versions: 0.9.1
> Reporter: Dave Brosius
> Priority: Trivial
>
> Looking at the thrift generated code for cassandra, i'm seeing
> msg = (org.apache.thrift.TBase)new
> org.apache.thrift.TApplicationException(org.apache.thrift.TApplicationException.INTERNAL_ERROR,
> e.getMessage());
> as seen here
> https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=blob;f=interface/thrift/gen-java/org/apache/cassandra/thrift/Cassandra.java;h=837acfc0e964249fd62720420e8f1f85d966f1a3;hb=8f202895ab9e17c3d6bd4965924fd5f1ffc27f94#l6095
> i don't see how TApplicationException can be cast to TBase, and so i'd expect
> a ClassCastException there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
