[ 
https://issues.apache.org/jira/browse/THRIFT-2820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389620#comment-14389620
 ] 

ASF GitHub Bot commented on THRIFT-2820:
----------------------------------------

Github user henrique commented on the pull request:

    https://github.com/apache/thrift/pull/413#issuecomment-88279965
  
    Hi Paul,
    Thanks for the PR. It looks pretty good, but have tried to remove the 
jQuery dependency?
    As you mentioned on your comments, I also think it make more sense if we 
didn't need it but I am not completely sure if you can run $http only with 
jqLite...


> Implement an alternative Transport for JS using the AngularJS $http-service
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-2820
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2820
>             Project: Thrift
>          Issue Type: New Feature
>          Components: JavaScript - Library
>    Affects Versions: 0.9.2
>         Environment: AngularJS, Browser
>            Reporter: David Sautter
>            Priority: Minor
>              Labels: features
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Since the architecture of the Thrift-library for Javascript-clients allows us 
> to use custom Transports, I would like to have a Transport using the 
> AngularJS $http-service. This would allow us to mock a Thrift Server in Tests 
> as well as intercepting and customizing Thrift requests (e.g. authentication).
> The Tansport can be included into your AngularJS App via a module so that you 
> can use it to instantiate your clients.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to