[
https://issues.apache.org/jira/browse/THRIFT-3086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484211#comment-14484211
]
Roger Meier commented on THRIFT-3086:
-------------------------------------
Thanks for the fixes Jim!
Yes, please stop using brackets for the commit and PR title, it confused
_asfgit robot_ and _git am_.
I've just updated CONTRIBUTING.md with details on commit messages and branch
names.
-roger
;-r
PS: I think Valgrind's memcheck, helgrind, cppcheck, strong compiler warnings,
multiple compilers and of course unit tests are sufficient for the moment.
There is no real need for coverity from my perspective. The only interesting
question is, do they a better job as the community driven QA tools?
... another todo: add memcheck and helgrind to CMake build and .travis.yml
> C++ Valgrind Error Cleanup
> --------------------------
>
> Key: THRIFT-3086
> URL: https://issues.apache.org/jira/browse/THRIFT-3086
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9.2
> Reporter: James E. King, III
> Assignee: Roger Meier
> Priority: Minor
> Fix For: 0.9.3
>
>
> valgrind identified a few issues in the C++ library:
> 1. In TFileTransport, inconsistent use of malloc then delete[]
> 2. In ZLibTest, leaking allocations
> 3. In RecursiveTest, leaking allocation
> These are minor, but a clean valgrind run is a happy valgrind run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
