Github user ben-craig commented on a diff in the pull request: https://github.com/apache/thrift/pull/424#discussion_r28189195 --- Diff: lib/cpp/src/thrift/server/TSimpleServer.cpp --- @@ -88,7 +88,7 @@ void TSimpleServer::serve() { string errStr = string("Some kind of accept exception: ") + tx.what(); GlobalOutput(errStr.c_str()); continue; - } catch (string s) { + } catch (const string& s) { --- End diff -- I don't know of any code in thrift that intentionally throws a string. Throwing a string (or anything without a vtable really) is certainly a poor practice.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---