Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/433#discussion_r28189373
--- Diff: lib/cpp/src/thrift/server/TThreadPoolServer.cpp ---
@@ -146,9 +73,12 @@ void TThreadPoolServer::serve() {
shared_ptr<TProcessor> processor = getProcessor(inputProtocol,
outputProtocol, client);
// Add to threadmanager pool
- shared_ptr<TThreadPoolServer::Task> task(
- new TThreadPoolServer::Task(*this, processor, inputProtocol,
outputProtocol, client));
- threadManager_->add(task, timeout_, taskExpiration_);
+ shared_ptr<TConnectedClient> pClient(
--- End diff --
I think you are referring to shared_from_this. Here are some of the boost
docs talking about the difference:
http://www.boost.org/doc/libs/1_57_0/libs/smart_ptr/enable_shared_from_this.html
http://www.boost.org/doc/libs/1_57_0/libs/smart_ptr/make_shared.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
