Github user bufferoverflow commented on a diff in the pull request:
https://github.com/apache/thrift/pull/434#discussion_r28203488
--- Diff: build/cmake/DefinePlatformSpecifc.cmake ---
@@ -58,8 +58,9 @@ if(MSVC)
endif(WITH_MT)
endif(MSVC)
-# GCC Specific
-if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
+# GCC or Clang specific
+if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR
CMAKE_CXX_COMPILER_ID MATCHES "Clang")
--- End diff --
does CMAKE_COMPILER_IS_CLANG work as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
