[ https://issues.apache.org/jira/browse/THRIFT-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492894#comment-14492894 ]
ASF GitHub Bot commented on THRIFT-2441: ---------------------------------------- Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/424#discussion_r28269576 --- Diff: lib/cpp/src/thrift/transport/TSocket.cpp --- @@ -493,29 +585,9 @@ uint32_t TSocket::read(uint8_t* buf, uint32_t len) { goto try_again; } -#if defined __FreeBSD__ || defined __MACH__ if (errno_copy == THRIFT_ECONNRESET) { - /* shigin: freebsd doesn't follow POSIX semantic of recv and fails with - * THRIFT_ECONNRESET if peer performed shutdown - * edhall: eliminated close() since we do that in the destructor. - */ return 0; } -#endif - -#ifdef _WIN32 --- End diff -- I spent a few hours trying to get a MinGW environment set up, but I wasn't able to so I am switching to Cygwin instead. Is there a MinGW 64-bit environment out there that has everything you need for Thrift? MinGW-w64 seemed like it had promise but it was missing the autotool chain. > Cannot shutdown TThreadedServer when clients are still connected > ---------------------------------------------------------------- > > Key: THRIFT-2441 > URL: https://issues.apache.org/jira/browse/THRIFT-2441 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.9.1 > Reporter: Chris Stylianou > Assignee: Ben Craig > Attachments: THRIFT-2441-prelim.patch > > > When calling stop() on the TThreadedServer no interrupts are sent to the > client threads. This means the stop() call blocks on tasksMonitor.wait() > until all client naturally disconnect. > How can we tell the client thread connections to close/exit during the > TThreadedServer::stop() call? -- This message was sent by Atlassian JIRA (v6.3.4#6332)